append applied_flows container before filling instead of after #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e consistent using empty sets intead of lists)
|
There is a change in the fifo depth optimization discussed in in in #642, basically getting rid of the explict, out of flow write called from the optimizer, that would make this change unnecessary in the case I mentioned, though this change would still be beneficial, I believe. |
This was referenced Aug 23, 2022
|
I think this change should go in since it fixes the current fifo depth optimization, and even if we change how we do the optimization, this will have no ill effect. |
|
Any more thoughts on this? I have to tell people to use it if they are doing fifo depth optimization, which is a bit annoying. |
vloncar
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change simply appends
applied_flowstoModelGraph._applied_flowsin the beginning, before it is filled, so thatModelGraph._applied_flowsalways has an accurate description of what has been applied. This is important in the FIFO depth optimization, because theFifoDepthOptimizationruns the writer flow outside of the main flow, before the flow is finished and beforeModelGraph._applied_flowsis updated, so currently it seesModelGraph._applied_flows == [], and since the writer depends on'vivado:ip', all the optimizers are run again, which sometimes messes things up. For example, running on a ResNet sample, rerunning the optimizers changes a type from beingPackedTypeto just beingFixedPrecisionType, causing it to fail. This way,ModelGraph._applied_flowsis always current so the out of main flow writer does not run'vivado:ip'again.I also updated a few empty lists to empty sets so that applied_flows is always a dictionary of sets, not a dictionary of sets or empty lists.
Type of change
Tests
The main test is to see that this doesn't break the current pytests. The FIFO optimization is too long to run as a standard test.
Checklist